apply page #592
apply page #592
Conversation
|
[diff-counting] Significant lines: 396. |
|
Make sure to fix all the lint errors here: |
|
Make sure to follow the designs for the tablet and mobile views as well to ensure that the component is responsive to changes in screen size. Use the tailwind breakpoints for |
There was a problem hiding this comment.
Great work so far, Kevin! :) The responsiveness still seems a bit off from the Figma designs, when I go to tablet mode. For example, the "Down to Innovate" blurb gets pushed down a screen height. Also, one thing I learned is that Tailwind supports custom inputs, which you might want to consider doing. I left some comments talking about this.
Another note: To keep the same organization as IDOL frontend and the other pages of this website, I think it would be best for ApplyTimeline to be put in an apply subfolder of components.
| <h1 className="text-4xl font-semibold mb-4"> | ||
| This is DTI. | ||
| </h1> | ||
| <p className="text-3xl font-semibold mb-4">developing, designing, delivering.</p> |
There was a problem hiding this comment.
nit: the d in developing should be capitalized
|
@kevinmram could you also rebase against main or merge main into this branch? The branch has fallen a bit behind and the deploy preview won't work until we pick up the node downgrade. |
|
@cchrischen is taking on this change and will open up a new PR! |
finished (v1.0) of the apply page - 'hero' component, according to the Figma.
However, it isn't exactly as the design intended- will make any necessary changes/updates.
Furthermore, I started an initial implementation of the 'timeline' component, inserted below the 'hero' component.