Refactor isCommunity field #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 44. |
andrew032011
approved these changes
Feb 29, 2024
| @@ -104,7 +104,7 @@ const TeamEventDashboard: React.FC = () => { | |||
| 0 | |||
| ); | |||
| const initiativeCredits = teamEvents.reduce( | |||
| (val, event) => calculateInitiativeCreditsForEvent(member, event), | |||
| (val, event) => val + calculateInitiativeCreditsForEvent(member, event), | |||
| @@ -53,7 +55,8 @@ const TeamEventForm = (props: Props): JSX.Element => { | |||
| date: teamEventDate, | |||
| numCredits: teamEventCreditNum, | |||
| hasHours: teamEventHasHours, | |||
| isCommunity | |||
| isCommunity: isInitiativeEvent, | |||
andrew032011
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isCommunityfield toisInitiativeEventin FEisInitiativeEventwhen requesting all team event infoThis pull request is the second step towards implementing support for initiative TEC
Notion/Figma Link
https://www.notion.so/TEC-Add-support-for-Initiative-tec-279c8cac37124630b2b7d7f383c70e55
Test Plan
Notes
isCommunityis still referenced in some files to be safe, namely inindex.d.tsandTeamEventForm.tsxwhen editing an event. In the latter case,isCommunityis updated to the value ofisInitiativeEvent.Breaking Changes