Remove pending field dependency for TEC #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 7. |
backend/src/types/DataTypes.d.ts
Outdated
| @@ -37,7 +37,7 @@ export type DBTeamEventAttendance = { | |||
| hoursAttended?: number; | |||
| image: string; | |||
| eventUuid: string; | |||
| pending: boolean; | |||
| pending?: boolean; | |||
There was a problem hiding this comment.
I think we'll be ok to remove this field entirely, since we're not using it. Note that even if the data in the database has this field, you won't have a "type error" due to extra fields that the type doesn't have.
common-types/index.d.ts
Outdated
| @@ -87,7 +87,7 @@ interface TeamEventAttendance { | |||
| hoursAttended?: number; | |||
| image: string; | |||
| readonly eventUuid: string; | |||
| readonly pending: boolean; | |||
| readonly pending?: boolean; | |||
There was a problem hiding this comment.
Same here as well, feel free to remove this field entirely, since we've fully migrated over to the status field.
andrew032011
approved these changes
Feb 10, 2024
andrew032011
approved these changes
Feb 11, 2024
alyssayzhang
approved these changes
Feb 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TEC's used to have both a "pending" and "status" field, which was redundant. The backend and frontend are updated to not use/depend on the pending field, and the pending field is made optional in data types. A script was run to remove the pending field from all Team Event Attendance collections in the dev database.
Notion/Figma Link
https://www.notion.so/TEC-Remove-dependency-on-Pending-field-8d7d76c75e2a46758da27620e890573c?pvs=4
Test Plan
To ensure removing the pending field in the dev database and updating the backend and frontend didn't mess with any functionalities, I tested each function that was modified locally (creating a team event attendance, submitting a team event attendance, etc.) and everything still works the same (for new and old data).