fixed landscape and mobile resizes #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 8. |
andrew032011
requested changes
Feb 3, 2024
|
Closing for now since the code is getting a little stale. Feel free to re-open when changes have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the styling on the hero page of the new DTI website reactive to different window sizes.
A window with standard sizing
This is the resizing that happens
And the image itself reactively gets smaller as the width of the window decreases.
Notion/Figma Link
Test Plan
Since this is a fully frontend styling task, there was no need for unit tests, and rather all the testing was done via the resizing of the window