Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break Word in Documentation Cell in Dev Portfolio Table #569

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

andrew032011
Copy link
Collaborator

Summary

We have a UI bug in the Dev Portfolio Details table due to longer documentation responses that are not being properly text-wrapped, so much so that some columns are not even visible unless you zoom out on a standard browser viewport.

Set max width of documentation column to be 200px and wrap the text.

Notion/Figma Link

Test Plan

Before:
Screenshot 2023-12-03 at 2 29 39 PM

After:
Screenshot 2023-12-03 at 2 29 16 PM

Notes

Breaking Changes

@andrew032011 andrew032011 requested a review from a team as a code owner December 3, 2023 19:30
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 7.

Copy link
Contributor

@kevinmram kevinmram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + GOAT

@andrew032011 andrew032011 merged commit d8f3359 into main Dec 3, 2023
13 checks passed
@andrew032011 andrew032011 deleted the u/axc/break-word-in-documentation-cell branch December 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants