potential save course fix #964
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default collection functionality changed - courses in default collection can only be removed by specifically removing that course from the default collection
|
[diff-counting] Significant lines: 21. |
|
Visit the preview URL for this PR (updated for commit f00b29a): https://cornelldti-courseplan-dev--pr964-savedcourses-fixes-hpuztrf4.web.app (expires Tue, 17 Dec 2024 22:25:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
nidhi-mylavarapu
requested changes
Nov 18, 2024
| @@ -162,6 +162,11 @@ export default defineComponent({ | |||
| collection => !this.checkedCollections.includes(collection) | |||
| ); | |||
|
|
|||
| // If no specific collections were selected, and no prevoius selections were removed, add to 'All' | |||
| if (addedToCollections.length === 0 && deletedFromCollections.length === 0) { | |||
| console.log('added to All'); | |||
There was a problem hiding this comment.
Just to clarify the functionality:
anytime you save any course, it should end up in the "all" collection, whether you add it to another specific collection or not?
There was a problem hiding this comment.
Also, on a completely separate note, should the other drop downs for collections close if you open a different one? That is, is it possible for all of the collection drop downs to be open at the same time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step potentially fixing save Courses default collection functionality
Test Plan
Notes
May not change the functionality based on future user reviews
Blockers
Breaking Changes