Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding AI minor #946

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adding AI minor #946

wants to merge 4 commits into from

Conversation

nit0107
Copy link
Collaborator

@nit0107 nit0107 commented Oct 16, 2024

Summary

  • added AI minor!

@nit0107 nit0107 requested a review from a team as a code owner October 16, 2024 22:27
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 16, 2024

[diff-counting] Significant lines: 147.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Visit the preview URL for this PR (updated for commit 08ab9c4):

https://cornelldti-courseplan-dev--pr946-nmp79-aiminor-5ifmzzj0.web.app

(expires Thu, 28 Nov 2024 20:01:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

{
name: 'Human-AI Interaction',
description: 'Add Core Course 3',
//TODO: add INFO 3450 exception for students grad in dec 2024 or may 2025
Copy link
Contributor

@plumshum plumshum Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space between // and TODO.
We should do a requirement migrations to accommodate different major requirements based on entry year. You can check out this documentation for it! This would be under a modification
Something along the lines of
image

then follow the instructors for index.ts and running the commands in your terminal, then you should be all set!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps same idea for CS 4780/CS3780

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the requirement migration details, hannah! yes - we would want to add something like this. make sure that the file for the AI minor has the current requirements and the migration is for previous requirements

slotNames: ['Course'],
},
{
name: 'AI Electives',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidhi-mylavarapu make sure this cross listing (bug?) does not break the functionality.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this was a weird bug -- grabbing a course from the first bucket shouldn't cause the courses in the second bucket to change to their cross listed names. I would look for another major or minor that requires you to select 2/n courses to fulfill a requirement and repeat that functionality.

Copy link
Contributor

@plumshum plumshum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi nice code so far! I'm super excited to finally and my requirements for AI. I think we should also remove some fields such as Course , ifCodeMatch, etc, since it was defined but never used. If you don't see it on ur end on vscode, maybe it's because prettier isn't running?
Also added some potential solutions for some of your TODOs
There is a potential? bug for selecting the AI Electives. Will let Nidhi also look at it too. Good job!!


export default aiMinorRequirements;

// export const aiMinorAdvisors: AdvisorGroup = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead, should we add [email protected]](mailto:[email protected]). it's not an actual person but it's good contact information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants