compose: Fix handling of base rev #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I definitely tested the previous patch (and so did Joseph) but I am fearing that I did further cleanup before pushing that broke it. What we're seeing right now is a segfault trying to use this with RHCOS (which notably doesn't have a `ref` in the treefile). Anyways, we should only be trying to resolve the base rev in the "outside" path, not the in-container path. (Right now, but once we can depend on a newer ostree inside the container we can actually make this all work symmetrically)
|
Looking at the PR history, I think what happened is:
https://github.com/coreos/rpm-ostree/compare/cec7714624b2764b4fc68cae8b6123e29835485e..526140928a7e595430cfebe3b374e9c577930d54# |
jlebon
approved these changes
Mar 31, 2022
Yeah definitely...I was hoping to wire things up more in a real e2e fashion alongside openshift/os#763 (Basically we start testing rhcos builds here too, including this container extensions flow) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I definitely tested the previous patch (and so did Joseph)
but I am fearing that I did further cleanup before pushing
that broke it.
What we're seeing right now is a segfault trying to use this with
RHCOS (which notably doesn't have a
refin the treefile).Anyways, we should only be trying to resolve the base rev in
the "outside" path, not the in-container path. (Right now, but
once we can depend on a newer ostree inside the container we can
actually make this all work symmetrically)