cmd-push-container-manifest: add container tags pushed to meta.json
#3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: #3129 |
For FCOS, we'll eventually want to add the oscontainer image in the stream metadata. We'll want it to be tag-based so that by default, users always use the latest release. Add a `tags` key to the image definition for this. We include all the tags instead of just e.g. the first one, because I think it's good practice to have `meta.json` reference all the external resources that it pushed to. This is important for example for GC.
jlebon
force-pushed
the
pr/copy-container-prep-tags
branch
from
7f487de to
05ad942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FCOS, we'll eventually want to add the oscontainer image in the
stream metadata. We'll want it to be tag-based so that by default, users
always use the latest release.
Add a
tagskey to the image definition for this.We include all the tags instead of just e.g. the first one, because I
think it's good practice to have
meta.jsonreference all the externalresources that it pushed to. This is important for example for GC.