cmd-push-container: fix --name-suffix semantics #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I misunderstood the original intent of this switch while reworking it. The idea is to add a suffix to the image tag, not its name. Fix it, and rename the switch accordingly. While we're here, add a metavar to `name` to make it clear that an optional tag can also be provided. Fixes c462739 ("cmd-push-container: replace --base-image-name by --name-suffix"). Closes: openshift/os#847
cgwalters
approved these changes
Jun 15, 2022
miabbott
approved these changes
Jun 15, 2022
|
Nothing in CI covers this so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misunderstood the original intent of this switch while reworking it.
The idea is to add a suffix to the image tag, not its name.
Fix it, and rename the switch accordingly.
While we're here, add a metavar to
nameto make it clear that anoptional tag can also be provided.
Fixes c462739 ("cmd-push-container: replace --base-image-name by
--name-suffix").
Closes: openshift/os#847