Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push-container: Actually use tag to push #2917

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

cgwalters
Copy link
Member

Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters
Copy link
Member Author

/override ci/prow/rhcos
Need to update CI here for that

@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos

In response to this:

/override ci/prow/rhcos
Need to update CI here for that

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit 7f87a9d into coreos:main Jun 14, 2022
@jlebon
Copy link
Member

jlebon commented Jun 14, 2022

Sorry, had a pending review here but then had more meetings. Pushed some tweaks to the logic in #2920 which I think would make this code easier to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHCOS 4.11 x86_64: pushing oscontainer started failing
3 participants