Improve EIP 1102 Support #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous 1102 PR was not ideal: It was still using the account-polling logic for the `enable()` function, which meant if a user declined the login, it would keep re-requesting it in a loop. This version replaces the account polling with a `Connect` button on the no-accounts view, giving the user a graceful and patient place to initiate the login process in a way that should be compatible with all major web3 browsers. This broke the tests again, sorry about that, I kindof just got this good enough for my personal uses at the moment.
|
Looks like this. The button style could be edited with a single class:
|
|
Thanks! taking a look now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous 1102 PR was not ideal: It was still using the
account-polling logic for the
enable()function, which meant if a userdeclined the login, it would keep re-requesting it in a loop.
This version replaces the account polling with a
Connectbutton on theno-accounts view, giving the user a graceful and patient place to
initiate the login process in a way that should be compatible with all
major web3 browsers.
This broke the tests again, sorry about that, I kindof just got this
good enough for my personal uses at the moment.