Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

v3.4.1

Compare
Choose a tag to compare
@LucasRoesler LucasRoesler released this 07 May 11:17
1cd3f2b
fix: Do not throw errors for idle transactions during migration (#118)

Catch and ignore `pq: unexpected transaction status idle` errors when we
commit the migrations transaction.  We have not see the error in
practice when testing the recent changes to the migrations _but_ we do
see this in the unit tests for Hub. This error indicates that a
transaction has started, ie `BEGIN;` but that nothing has happened in
the transaction yet. A similar (but resolved) issue happened in the pq
driver, but the culprit (unclosed Rows) does not apply to our method,
all possible Row objects are automatically closed for us by the sql
methods. See https://github.com/lib/pq/issues/225

See also
https://www.postgresql.org/message-id/[email protected]

Signed-off-by: Lucas Roesler <[email protected]>