Skip to content

Commit

Permalink
Merge pull request #42 from Luap99/version
Browse files Browse the repository at this point in the history
Update podman version for testing
  • Loading branch information
openshift-merge-bot[bot] authored Nov 15, 2024
2 parents b20bb89 + a5c47a1 commit 194f4ca
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ verify_windows_task:
PATH: "${PATH};C:\\Program Files\\RedHat\\Podman"
MACHINE_IMAGE: "podman-machine.${ARCH}.hyperv.vhdx.zst"
MACHINE_IMAGE_URL: "https://api.cirrus-ci.com/v1/artifact/build/${CIRRUS_BUILD_ID}/Image Build ${ARCH}/image/${MACHINE_IMAGE}"
PODMAN_VERSION: 5.2.5
PODMAN_VERSION: 5.3.0
setup_script: .\contrib\cirrus\windows_setup.ps1
main_script: |
$Env:CONTAINERS_MACHINE_PROVIDER = "hyperv"
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/pr_image_links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ jobs:
- if: steps.retro.outputs.is_pr == 'true'
name: Print Artifacts output
id: artifact_output
run: ./contrib/cirrus/print-artifacts-urls.sh "${{ steps.retro.outputs.bid }}"
run: |
echo 'comment<<EOF' >> $GITHUB_OUTPUT
./contrib/cirrus/print-artifacts-urls.sh "${{ steps.retro.outputs.bid }}" >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
- if: steps.retro.outputs.is_pr == 'true'
name: Send GitHub PR comment
Expand All @@ -75,4 +78,4 @@ jobs:
# the tag causes it to replace the comment
comment-tag: artifacts
mode: recreate
message: ${{ steps.artifact_output.outputs.stdout }}
message: "${{ steps.artifact_output.outputs.comment }}"
7 changes: 7 additions & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ fi

echo " Building image locally"

# Validate podman RPM type var, see the Containerfile for the pull logic.
case "${PODMAN_RPM_TYPE}" in
"dev") echo "Will install podman from the podman-next copr, the podman version is ignored" ;;
"release") ;;
*) echo 'PODMAN_RPM_TYPE must be set to "dev" or "release"' 1>&2; exit 1
esac

# See podman-rpm-info-vars.sh for all build-arg values. If PODMAN_RPM_TYPE is
# "dev", the rpm version, release and fedora release values are of no concern
# to the build process.
Expand Down
2 changes: 1 addition & 1 deletion contrib/cirrus/print-artifacts-urls.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
#!/usr/bin/env bash

CIRRUS_BUILD_ID=$1

Expand Down
5 changes: 3 additions & 2 deletions podman-rpm-info-vars.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
#!/usr/bin/env bash

# Set PODMAN_RPM_TYPE to anything other than "dev" to build release rpms.
# Set to "dev" to pull from the podman-next copr, set to "release"
# to pull the ext rom from the fedora build system based of the versions below.
export PODMAN_RPM_TYPE="dev"

# If PODMAN_RPM_TYPE is "dev", the vars below don't end up getting used in the
# build
export PODMAN_VERSION="5.3.0~rc2"
export PODMAN_VERSION="5.4.0-dev"
export PODMAN_RPM_RELEASE="1"

0 comments on commit 194f4ca

Please sign in to comment.