Add handling for firewalld's StrictForwardPorts setting #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mheon
force-pushed
the
firewalld_detect_strict_port_forward
branch
from
ade567a to
9114d77
Compare
|
I don't think this actually generates + installs the manpage, need to figure that bit out, but the contents should be solid |
mheon
force-pushed
the
firewalld_detect_strict_port_forward
branch
2 times, most recently
from
b3a0733 to
33d2a4a
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mheon
force-pushed
the
firewalld_detect_strict_port_forward
branch
from
33d2a4a to
59f93a4
Compare
This mostly amounts to throwing a sensible error in cases where the setting is enabled and the user has requested ports be forwarded. There are no tests at present because firewalld 2.3.x is currently restricted to Rawhide, and is required for effective testing. A manpage has also been added with details on how to work with the StrictForwardPorts setting (as well as some other tidbits on firewalld + Podman integration). Signed-off-by: Matt Heon <[email protected]>
mheon
force-pushed
the
firewalld_detect_strict_port_forward
branch
from
59f93a4 to
6995211
Compare
|
@Luap99 PTAL, particularly at the manpage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly amounts to throwing a sensible error in cases where the setting is enabled and the user has requested ports be forwarded.
There are no tests at present because firewalld 2.3.x is currently restricted to Rawhide, and is required for effective testing.
A manpage has also been added with details on how to work with the StrictForwardPorts setting (as well as some other tidbits on firewalld + Podman integration).