[FIX] Issue #529: become plugin podman_unshare become_user default #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default Signed-off-by: Janos Gerzson <[email protected]>
sshnaidm
reviewed
Nov 30, 2022
| @@ -130,8 +129,8 @@ def build_become_command(self, cmd, shell): | |||
|
|
|||
| becomecmd = 'podman unshare' | |||
|
|
|||
| user = self.get_option('become_user') or '' | |||
| if user: | |||
| user = self.get_option('become_user') or 'root' | |||
There was a problem hiding this comment.
Shouldn't it be the current user by default?
There was a problem hiding this comment.
It will run as the current user (ansible_user) if become_user is root, or not set at all (by default).
Actually, if become_user has been set to anything but root it will be executed with sudo, otherwise no sudo applied.
I tested it and was working flawlessly.
There was a problem hiding this comment.
Thanks for clarification. I think we can add some tests here.
I'll prepare a test skeleton.
There was a problem hiding this comment.
You can use this as a template for tests: #531 Just replace podman_lovely_module by your module/plugin name everywhere.
grzs
commented
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janos Gerzson [email protected]