Add support to Prometheus #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HileQAQ
force-pushed
the
prometheus
branch
3 times, most recently
from
703730a to
2c8e560
Compare
BigVan
reviewed
Dec 16, 2022
cmd/overlaybd-snapshotter/main.go
Outdated
| @@ -64,6 +64,10 @@ func main() { | |||
| } | |||
| logrus.Infof("%+v", *pconfig) | |||
|
|
|||
| if pconfig.MonitorPort != "" { | |||
There was a problem hiding this comment.
Add MonitorPort in config.json ?
HileQAQ
force-pushed
the
prometheus
branch
2 times, most recently
from
159180b to
490442c
Compare
|
@HileQAQ remove this binary? cmd/overlaybd-snapshotter/overlaybd-snapshotter |
liulanzheng
reviewed
Jan 12, 2023
docs/PROMETHEUS.md
Outdated
| "logReportCaller": false, | ||
| "autoRemoveDev": false, | ||
| "exporterConfig": { | ||
| "enable": false, |
Signed-off-by: Haoqi Miao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can provide a port (for example, in
/etc/overlaybd-snapshotter/config.json, we setmonitorPort: 9099) for prometheus to monitor some metrics like GRPC APIs latency or error count.(from #140)
Signed-off-by: Haoqi Miao [email protected]