Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: fix missing attribute error #2095

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Jul 16, 2024

Timeout and RetryError exception doesn't return HTTP code, handle it in separate
except clause.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

Timeout and RetryError expception doesn't return HTTP code, handle it in separate
except clause.

Signed-off-by: Martin Basti <[email protected]>
@MartinBasti MartinBasti merged commit 5a1396b into containerbuildsystem:master Jul 16, 2024
8 of 11 checks passed
@MartinBasti MartinBasti deleted the fix-mypy branch July 16, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants