Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature async render #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PhotoAtomic
Copy link

This is my proposed solution to this issue
it was independently developed from the other PR which I've noticed exist only after the facts :( sorry

This solution leverages on the already existing NextRender task without introducing additional synchronization mechanisms like semaphores.
As said in the above mentioned issue, the solution have a little of code duplication, there are easy way to fix it and i'm happy to apply the preferred one, let's just discuss it. options are:

  • move common code in a separate method:
    Pros: easy code, Cons: the method should return more than one value => introduced a new return type with multiple properties or uses anonymous records.
  • make the divergent portion of code to be called as delegate passing multiple argument to it
    Pros: avoid generation of new types, Cons: less simple code, force to return Task and in case ignore it when not needed
  • other...? let's discuss!

I probably prefer the first :)

…en all the async lifecycle events are completed, and contains html with the latest updates from the completion of the async lifecycle methods
@PhotoAtomic
Copy link
Author

I propose to evaluate #30 instead of this one, because this solution was too rushed and doesn't supports certain scenarios at its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants