Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just build noarch canaries #493

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Just build noarch canaries #493

merged 3 commits into from
Jul 17, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jul 16, 2024

Description

Canary builds are failing due to a subdirectory mismatch. Since there's support for noarch now, let's build that directly.

Closes #491

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 16, 2024
@jaimergp jaimergp marked this pull request as ready for review July 17, 2024 08:22
@jaimergp jaimergp requested a review from jezdez July 17, 2024 10:59
@@ -755,13 +745,13 @@ jobs:
Path(environ["GITHUB_ENV"]).write_text(f"ANACONDA_ORG_LABEL={label}")

- name: Create & Upload
uses: conda/actions/canary-release@v24.2.0
uses: conda/actions/canary-release@v24.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: conda/actions/[email protected]
uses: conda/actions/canary-release@976289d0cfd85139701b26ddd133abdd025a7b5f # v24.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a subsequent PR so we pin everything and add dependabot, thanks!

@jaimergp jaimergp merged commit ab4fb72 into main Jul 17, 2024
63 checks passed
@jaimergp jaimergp deleted the simplify-canary-builds branch July 17, 2024 14:20
@jaimergp jaimergp mentioned this pull request Jul 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Canary builds are failing
3 participants