-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail gracefully if offline and no cache is available #323
Conversation
b986f1c
to
2044580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and can confirm in pytest tests/test_create.py -k test_offline_with_empty_index_cache\[libmamba\]
that the test continues but still does eventually fail. The error messages though are more helpful in debugging.
I will be investigating the tests that fail and why it is happening reliably on windows. https://github.com/conda/conda-libmamba-solver/actions/runs/6513586579/job/17735028419?pr=323#step:9:935 |
Triggering a rerun and seeing what happens. I ran this test locally on a windows vm and wasn't able to reproduce. |
Spent a long time trying to debug the windows issue. I see a difference of |
I'd say we skip it for now because it's not solver related at all. Can you deselect in the pytest collection plugin? Thanks! |
Makes sense, but this is what we observe in this error:
We didn't see this error earlier because the packaging situation is unique: |
Note that changing the ENVIRONMENT_PYTHON_PIP_CLICK = f"""
name: {TEST_ENV_NAME_1}
dependencies:
- - python=3
+ - python
- pip
- pip:
- click
channels:
- defaults
""" |
This alternative change in self.specs_to_add = IndexedSet(MatchSpec.merge(s for s in fixed_specs)) However, if we prio Python, it passes: resorted_specs = []
for spec in MatchSpec.merge(s for s in fixed_specs):
if spec.name == "python":
resorted_specs.insert(0, spec)
else:
resorted_specs.append(spec)
self.specs_to_add = IndexedSet(resorted_specs) |
Description
Needed for conda/conda#12984
Checklist - did you ...
news
directory (using the template) for the next release's release notes?