Skip to content

Commit

Permalink
Update to node20
Browse files Browse the repository at this point in the history
node16 is eol, thus updating. See also https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Many popular actions (like checkout) already updated and everything should
work fine.

The entire package-lock.json was regenerated via node20.

Also explicitly setting the node version in the lint action.
  • Loading branch information
dbast committed Nov 22, 2023
1 parent 9f54435 commit 43c52f7
Show file tree
Hide file tree
Showing 5 changed files with 52,237 additions and 11,589 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ convention, are also checked in.

- Create Conda env with `nodejs`:

We use NodeJS version 16 for now.
We use NodeJS version 20 for now.

```bash
conda create -n github-action nodejs=16 -c conda-forge
conda activate
conda create -n github-action nodejs=20 -c conda-forge
conda activate github-action
```

- Install NodeJS dependencies:
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ author: Gonzalo Peña-Castellanos (@goanpeca)
description: "Set up Conda package and environment manager with Miniconda."

runs:
using: "node16"
using: "node20"
main: "dist/setup/index.js"
post: "dist/delete/index.js"
post-if: "success() && env.INPUT_RUN_POST == 'true'"
Expand Down
Loading

0 comments on commit 43c52f7

Please sign in to comment.