Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.8 to be tested as well #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Python 3.8 to be tested as well #51

wants to merge 5 commits into from

Conversation

marcelotrevisani
Copy link
Member

No description provided.

@marcelotrevisani marcelotrevisani added the enhancement New feature or request label Nov 4, 2019
@marcelotrevisani
Copy link
Member Author

There is no Python 3.8 on Azure... That is funny...
Let's wait a couple of weeks to see if they are going to add it

@marcelotrevisani
Copy link
Member Author

@scopatz
Copy link
Contributor

scopatz commented Nov 4, 2019

ok!

@henryiii
Copy link

henryiii commented Nov 4, 2019

It's landed on Github Actions, and is rolling out on Azure; I would expect it soon.

@marcelotrevisani
Copy link
Member Author

Well, now we have Python 3.8. However, we do not have the whole dependencies on conda-forge for python 3.8 😅

@scopatz
Copy link
Contributor

scopatz commented Nov 8, 2019

yeah, I think we need to wait until the dependencies are there too

@marcelotrevisani
Copy link
Member Author

It seems there is a bug on xonsh which needs to be addressed or we can pin an older version of xonsh.

@scopatz
Copy link
Contributor

scopatz commented Dec 3, 2019

Yeah, I should release a new version of xonsh. Hopefully I can get to that today.

@scopatz
Copy link
Contributor

scopatz commented Dec 3, 2019

Or rather @marcelotrevisani - what do you think the bug is?

@marcelotrevisani
Copy link
Member Author

Or rather @marcelotrevisani - what do you think the bug is?

I didn't investigate it much further (because I'm still at my work), but it seems the shell object was not created and it is returning a None object. The reason behind it I still don't know.

So, basically it calls the print_color

def print_color(string, **kwargs):
    """Prints a string that may contain colors. This dispatched to the shell
    method of the same name. Colors will be formatted if they have not already
    been.
    """
    builtins.__xonsh__.shell.shell.print_color(string, **kwargs)

However, builtins.__xonsh__.shell is returning None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants