-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow v2.18.0 #408
tensorflow v2.18.0 #408
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.11.09.23.22.20
…nda-forge-pinning 2024.11.10.22.41.52
yes, but somebody has to the hard work of getting the patches updated. |
d488a43
to
db1e370
Compare
I cancel the running CI. As pointed at #405 (comment), the CI hangs at tensorflow/tensorflow@9b5fa66#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2c |
Thanks for the comment! I was a bit away (longer than expected) and did not remember on what my local changes were. They are related to the new hermetic CUDA. Someone should port the stuff I did in jaxlib over here. |
Side note: It is possible to Here is a simple example of this behavior from Linux ARM conda create -n tst_cuda_stub python=3.12 ipython cuda-nvcc
conda activate tst_cuda_stub In [1]: import ctypes
In [2]: ctypes.cdll.LoadLibrary(
...: "/opt/conda/envs/tst/targets/sbsa-linux/lib/stubs/libcuda.so"
...: )
Out[2]: <CDLL '/opt/conda/envs/tst/targets/sbsa-linux/lib/stubs/libcuda.so', handle aaaacafa37c0 at 0xffff85e2e720> Am just not clear on why the TensorFlow wants to load |
We have an explicit requirement on tensorflow-feedstock/recipe/meta.yaml Lines 261 to 262 in dd13456
So we already don't support that (well, unless someone uses CONDA_CUDA_OVERRIDE ). I'm not saying that losing this ability would be desirable, just trying to figure out why it's a concern in the first place.
|
I think this is a fair question. The reason that
I am personally in camp 2, though, years ago, I was in camp 1. If I recall correctly, one of the (many) reasons we added |
I mean, how well can you test your setup if you're on a system that will end up taking completely different code paths (CPU vs. GPU) compared to the target environment? In any case, I'm in favour of keeping the ability to run without a GPU driver, but at the same time, I don't think it's worth an extreme maintenance investement if indeed upstream tensorflow now requires that. |
According to their docs, no GPU should be needed at build time 🤔 ![]()
|
Ok we could add the stub library to the library search path at build time |
Although bazel is able to download cuda including drivers, in conda-forge, we set the environment variable Related documentation can be found here: https://github.com/openxla/xla/blob/main/docs/hermetic_cuda.md "When CUDA forward compatibility mode is disabled, Bazel targets will use User Mode and Kernel Mode Drivers pre-installed on the system." |
JFYI, we're currently building stuff on pytorch that's occupying the only available GPUs (half of them are currently offline too). Just in case you're wondering why stuff might not start. C.f. also conda-forge/pytorch-cpu-feedstock#314 |
The builds looks like they're passing on linux now. Is someone available to build the OSX side of things? I'd like to cancel the builds here for now to get in a big pytorch PR, especially since we need to still figure out osx builds here (and IMO we should include #411 before merging). Thoughts @njzjz @hmaarrfk @xhochy @ngam @conda-forge/tensorflow? |
I can build stuff. I haven't had time to catch up on any conda-forge stuff since Christmas but once this is in a buildable shape, feel free @h-vetinari to drop me a DM in the usual channls so that I actually look at it. |
I am okay with this. |
this doesn't even feel rerendered with the latest abseil on conda-forge wide. I'll try to build locally. |
That's what I meant with my last comment.
Nice! With an abseil update, or as-is? |
With a rerender diff --git a/.ci_support/linux_64_c_compiler_version13cuda_compilerNonecuda_compiler_versionNonecxx_compiler_version13python3.10.____cpython.yaml b/.ci_support/linux_64_c_compiler_version13cuda_compilerNonecuda_compiler_versionNonecxx_compiler_version13python3.10.____cpython.yaml
index 81a4855..07907c6 100644
--- a/.ci_support/linux_64_c_compiler_version13cuda_compilerNonecuda_compiler_versionNonecxx_compiler_version13python3.10.____cpython.yaml
+++ b/.ci_support/linux_64_c_compiler_version13cuda_compilerNonecuda_compiler_versionNonecxx_compiler_version13python3.10.____cpython.yaml
@@ -37,13 +37,13 @@ libabseil:
libcurl:
- '8'
libgrpc:
-- '1.65'
+- '1.67'
libjpeg_turbo:
- '3'
libpng:
- '1.6'
libprotobuf:
-- 5.27.5
+- 5.28.3
nccl:
- '2'
numpy: |
The CPU build completed, but the cuda build error'ed with:
|
That's because the GPUs are currently physically offline: conda-forge/status#189 |
this is on my machine locally. I guess I missed when we made it mandatory to expose the GPUs we have to docker (I have a GPU on the machine i compiled on). can we revert this mandatory need so i can compile things locallyy? |
I think it's tensorflow itself that changed to require finding cuda at build time. If you manage to patch that out, that would be great, then we could build on CPU agents |
Hopefully this:
fixes things. |
…nda packages Imported from GitHub PR #20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving tensorflow/tensorflow#56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85c by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20288 from traversaro:fixloadcudaconda a2ce85c PiperOrigin-RevId: 717411600
…nda packages Imported from GitHub PR openxla/xla#20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving #56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85cf9df1ede3f3c1843ede55d4c76673910e by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#20288 from traversaro:fixloadcudaconda a2ce85cf9df1ede3f3c1843ede55d4c76673910e PiperOrigin-RevId: 717411600
…nda packages Imported from GitHub PR #20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving tensorflow/tensorflow#56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85c by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20288 from traversaro:fixloadcudaconda a2ce85c PiperOrigin-RevId: 717411600
…nda packages Imported from GitHub PR #20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving tensorflow/tensorflow#56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85c by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 COPYBARA_INTEGRATE_REVIEW=#20288 from traversaro:fixloadcudaconda a2ce85c PiperOrigin-RevId: 717440484
…nda packages Imported from GitHub PR openxla/xla#20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving #56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85cf9df1ede3f3c1843ede55d4c76673910e by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 PiperOrigin-RevId: 717440484
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11511568857 - please use this URL for debugging.