Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for grpc_cpp141 #180

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update grpc_cpp141.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1490026954, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

are you going to try to build this @xhochy ??

if so, why not skip it and build the next version

#177

@h-vetinari
Copy link
Member

I'm happy to do a version of #176 without bumping to 2.7.0 if we need a new grpc build out the door faster. Do we need to cover every version? Otherwise I'd go straight to 1.42 as well

@xhochy
Copy link
Member

xhochy commented Nov 26, 2021

Ah, I just picked one PR that looked nice yesterday evening to run overnight. The builds have passed. I can upload them, then we could move ahead with this PR. I know it probably would not have been needed but it was too late 🤦 . I can build the other grpc migration tonight. Or is there anything in #175 that should have been part of this?

@h-vetinari
Copy link
Member

I can build the other grpc migration tonight.

I mean, I don't think anyone's stopping you 😅

My personal calculus was that the fastest reasonable cadence would be a build every ~2-3 weeks (due to the manual effort involved and not wanting to be demanding of this scarce resource) - hence collecting as many things as possible into the builds we do do (#175).

Or is there anything in #175 that should have been part of this?

If you do plan to run another build overnight, I think we should cherry-pick the following:

@xhochy
Copy link
Member

xhochy commented Dec 1, 2021

@wolfv Gentle ping for approval here.

@xhochy
Copy link
Member

xhochy commented Dec 3, 2021

@xhochy
Copy link
Member

xhochy commented Dec 4, 2021

@conda-forge/tensorflow Can someone approve the PR here? I would interpret CFEP-03 as that it is sufficient that someone approves and then someone from core builds and uploads.

@xhochy xhochy merged commit 1551ab7 into conda-forge:master Dec 5, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-grpc_cpp141-0-1_h96459d branch December 5, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants