-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODOs for next build #175
Comments
Currently tensorflow here is not built against MKL (OneDNN), but do we plan to? |
Not sure how involved this is, but since onednn seems to be available for all relevant platforms, I'm not opposed to trying! |
Tensorflow is building oneDNN from source in the build currently. That is probably the first 1-2h of CI. Getting that from the feedstock instead of building from source would help a lot. |
That sounds like a big win if we can pull it off! |
Since rebuilding takes so much effort and we don't do it that often, I wanted to create an issue to track the various things we should adapt for the next build:
EDIT: "checked" below means it's currently included in #176
bazel-toolchain
(see Add cuda support bazel-toolchain-feedstock#5)cudatoolkit
as a dependency totensorflow
, or even better, get rid oftensorflow-base
(since it's not needed anymore now thattf-estimator
is built in this feedstock), see Help mamba decide on CUDA variant #162numpy
has been unpinned from 1.19.2 in TF 2.7 as of tensorflow/tensorflow@a90383a__cuda
virtual package or the GPU builds, see run-depend on__cuda
for cuda variants #174gilbertfrancois
from the maintainers: Bye #178libtensorflow{,_cc}
, see Buildlibtensorflow{,_cc}
also on osx/windows? #181.CC @hmaarrfk @xhochy @wolfv @conda-forge/tensorflow, feel free to add more things in the description. If any of those points end up being a huge hassle, it can of course be pushed off to the build after that.
Anyone is welcome to chime in if I forgot something. 🙃
The text was updated successfully, but these errors were encountered: