Skip to content

Commit

Permalink
clarify situation around TF_SYSTEM_LIBS
Browse files Browse the repository at this point in the history
  • Loading branch information
h-vetinari committed Nov 25, 2021
1 parent b439aec commit 53093db
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 4 deletions.
15 changes: 12 additions & 3 deletions recipe/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@ export CXX=$(basename $CXX)
export LIBDIR=$PREFIX/lib
export INCLUDEDIR=$PREFIX/include

# Upstream docstring for TF_SYSTEM_LIBS in:
# https://github.com/tensorflow/tensorflow/blob/v{{ version }}/third_party/systemlibs/syslibs_configure.bzl
# * `TF_SYSTEM_LIBS`: list of third party dependencies that should use
# the system version instead
#
# To avoid bazel installing lots of vendored (python) packages,
# we need to install these packages through meta.yaml and then
# tell bazel to use them. Note that the names don't necessarily
# match PyPI or conda, but are defined in:
# https://github.com/tensorflow/tensorflow/blob/v{{ version }}/tensorflow/workspace<i>.bzl

# Exceptions and TODOs:
# Needs a bazel build:
# com_google_absl
# Build failures in tensorflow/core/platform/s3/aws_crypto.cc
Expand All @@ -19,9 +31,6 @@ export INCLUDEDIR=$PREFIX/include
# com_github_googlecloudplatform_google_cloud_cpp
# Needs c++17, try on linux
# com_googlesource_code_re2

# The possible values are specified in third_party/systemlibs/syslibs_configure.bzl
# The versions for them can be found in tensorflow/workspace.bzl
export TF_SYSTEM_LIBS="
absl_py
astor_archive
Expand Down
8 changes: 7 additions & 1 deletion recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ requirements:
- m2-zip # [win]
- openjdk >=8
- nsync
# TF_SYSTEM_LIBS
# TF_SYSTEM_LIBS, see usage in
# https://github.com/tensorflow/tensorflow/blob/v{{ version }}/third_party/systemlibs/syslibs_configure.bzl
# their versions are specified in
# https://github.com/tensorflow/tensorflow/blob/v{{ version }}/tensorflow/workspace2.bzl
# but so far there have been no problems with leaving these
# unpinned; though some restrictions come in for packages
# that are also listed as a requirement for the pip_package.
- astor
- cython
- dill
Expand Down

0 comments on commit 53093db

Please sign in to comment.