Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe keras-nlp #21616

Closed
wants to merge 3 commits into from
Closed

Add recipe keras-nlp #21616

wants to merge 3 commits into from

Conversation

Anselmoo
Copy link
Member

@Anselmoo Anselmoo commented Dec 26, 2022 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-nlp) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-nlp) and found some lint.

Here's what I've got...

For recipes/keras-nlp:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [24]
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@Anselmoo
Update dependencies
0e37b81 
Update dependencies
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-nlp) and found some lint.

Here's what I've got...

For recipes/keras-nlp:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-nlp) and found some lint.

Here's what I've got...

For recipes/keras-nlp:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@Anselmoo
Add noarch: python
c0f781e 
Add `noarch: python`
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keras-nlp) and found it was in an excellent condition.

@Anselmoo
Copy link
Member Author

@conda-forge-admin, please rerender

@Anselmoo
Copy link
Member Author

@conda-forge/help-python

@Anselmoo Anselmoo marked this pull request as ready for review December 26, 2022 21:53
@Anselmoo
Copy link
Member Author

Anselmoo commented Jan 29, 2023 •
edited
Loading

See needed dependency conda-forge/autokeras-feedstock#1 (comment)

And https://github.com/tensorflow/text

@Anselmoo
Copy link
Member Author

@dopplershift can you please take a look, please?

BastianZim
BastianZim requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@BastianZim BastianZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things, then this is ready to go 🚀

recipes/keras-nlp/meta.yaml
- absl-py
- numpy
- packaging
- tensorflow >=2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream seems to require more: https://github.com/keras-team/keras-nlp/blob/3e9edab1032d1525541e4f57c8e6e31309265465/setup.py#L45

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BastianZim, thx for the feedback. I am aware of this dependency, but it looks like that recent PRs went through.

Will it be possible to install it via pip? Otherwise, a feedstock of tensorflow-text would make sense for NLP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we require all dependencies to be available on conda-forge and listed here so we would have to wait for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that ... in case of avoiding tensorflow-text via bazel would that ok like for catboost-feedstock?

IF "%PY_VER%"=="2.7" (
	%PYTHON% -m pip install --no-deps https://pypi.org/packages/cp27/c/catboost/catboost-%PKG_VERSION%-cp27-none-win_amd64.whl
)

IF "%PY_VER%"=="3.5" (
	%PYTHON% -m pip install --no-deps https://pypi.org/packages/cp35/c/catboost/catboost-%PKG_VERSION%-cp35-none-win_amd64.whl
)

IF "%PY_VER%"=="3.6" (
	%PYTHON% -m pip install --no-deps https://pypi.org/packages/cp36/c/catboost/catboost-%PKG_VERSION%-cp36-none-win_amd64.whl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it needs to be properly installed as a dependency.
You can also add it to conda-forge yourself, if you need the package?

Copy link
Member Author

@Anselmoo Anselmoo Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So first setup open a new feedstock for tensorflow-text and with package from scratch not like catboost?

For the new version of AutoKeras they add keras-nlp as dependency, while it depends on tensorflow-text

conda-forge/autokeras-feedstock#1 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also: #19578 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, basically submit another PR for tensorflow-text or have it as an output in tensorflow. Not sure what the build process is there.

I'm not familiar with catboost but we always build from source. These exceptions are only made in very rare cases, where it is impossible to build it differently.

recipes/keras-nlp/meta.yaml

test:
imports:
- examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- examples
- examples
commands:
- pip check
requires:
- pip

To check the deps

@stale
Copy link

stale bot commented Jul 11, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Jul 11, 2023
@stale Stale
Copy link

stale bot commented Jan 1, 2024

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastianZim BastianZim BastianZim requested changes

Assignees
No one assigned
Labels
Awaiting author contribution python stale will be closed in 30 days
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anselmoo @conda-forge-linter @BastianZim