-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CFEP-25 noarch: python
syntax
#40
Rebuild for CFEP-25 noarch: python
syntax
#40
Conversation
…onda-forge-pinning 2025.01.10.08.48.29
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12710754124. Examine the logs at this URL for more detail. |
@melund I just reviewed this change ... apparently, this changes our minimum supported version from 3.8 to 3.9: Our current minimum Python version is 3.8: https://github.com/pymeasure/pymeasure/blob/master/pyproject.toml#L17, so this makes the conda-forge package go out of sync with our upstream/pypi package. Did you review this before merging? |
In addition I'm wondering, should you not have the time to review before merging, and seeing that you haven't been involved with pymeasure maintenance in a long long time, do you still want to be on the maintainers list for the feedstock here? |
That is odd. As I understand
Feel free to remove me. I am mostly on this, because I probably created the feedstock in the first place. |
We still want to keep the line See: https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python |
I noticed the same thing with pyleco (available for python 3.8). |
Documentation states:
...
From that I conclude, that we should define the lower limit manually. In this case, we should add a note to the release.md file as well. |
@BenediktBurger: Ok, then I think we should pin the version requirement manually to 3.8. For package like this with a good set of maintainers, that should not be a problem. |
@BenediktBurger, I made a PR to update the minimal python version to a hardcode value of 3.8: #45 |
Ah, 3.8 being EOL would be a good explanation! |
So, we don't change the Conda forge recipe (closing the pr @melund opened), but change the pymeasure master to 3.9 for the rext release, right? |
This PR updates the recipe to use the
noarch: python
syntax as described in CFEP-25. Please see our documentation for more details.If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12710663776 - please use this URL for debugging.