-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libprotobuf v24.3 #185
libprotobuf v24.3 #185
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
e6a66fc
to
ca2be8e
Compare
@h-vetinari What is blocking this to be merged? |
Mainly the progress (or lack thereof, at least previously) of the abseil/grpc/protobuf migration. Since we now have to migrate per protobuf-patch version - and because it affects hard-to-rebuild feedstocks like pytorch and tensorflow - I tend to stagger the migrations a bit (recently also coupled with grpc to reduce the load, see conda-forge/conda-forge-pinning-feedstock#4075). I was planning to do 4.24.x together with grpc 1.58, but I haven't fully debugged that build yet. But if there's a need for the new protobuf (due to pertinent bugfixes etc.), we can merge this and migrate directly. IMO the existing migration has progressed far enough to close it. |
…nda-forge-pinning 2023.09.25.15.21.40
ca2be8e
to
f6a2d80
Compare
For Tensorflow, currently, I feel like updating protobuf is the most likely path to succeed. I don't see a simple way to fix the mentioned protobuf+CUDA interactions. |
OK, let's merge this. I've done a bit of debugging for grpc 1.58, so we may be able to start the migration properly in any case. |
In any case, you can already pull this in for the tensorflow builds and "anticipate", the migration so to speak. |
MUST we do it together with grpc 1.58 or CAN we do it? I've seen some statements in the past, but my knowledge is not uptodate. |
It was necessary for the 4.x change, but we don't absolutely have to do it. It looks like 1.58 is only going to take a little bit more time though, so unless you need to start that migration in the next couple hours, we should still be able to couple them. |
Then let's do them together, Tensorflow is probably still 1-2 weeks away even if the migration helps. So there is no real time pressure. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #169
Closes: #179
Closes: #184
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6112976732, please use this URL for debugging.