Fix uninstallation of conda-forge-ci-setup #1596
Conversation
| - cmd: conda.exe uninstall --quiet --yes --force {{ " ".join(remote_ci_setup) }} | ||
| # Uninstall the conda-forge-ci-setup package but leave its dependencies | ||
| # so that we may bootstrap the installation process | ||
| - cmd: conda.exe uninstall --quiet --yes --force conda-forge-ci-setup |
There was a problem hiding this comment.
This was an option so the package could be renamed. We should preserve that.
There was a problem hiding this comment.
Then I think we have two options:
- Remove the uninstall step and specify each dependency to
conda-forge-ci-setupin theconda-forge.ymlfile. This seems quite difficult with win/osx/linux specifics. - Create a new option.
To be clear, I figured that "renaming" wasn't so interesting because of the hard coded nature of the package name:
https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/main/recipe/meta.yaml#L63
There was a problem hiding this comment.
The 3rd option is to leave it as is.
The current "state" works for tensorflow, and works for conda-forge-ci-setup. This is "good enough" for me.
There was a problem hiding this comment.
We actually have the version as part of the option:
conda-smithy/conda_smithy/configure_feedstock.py
Line 1759 in c299172
So smithy has been using a mix of things.
I don't have strong feelings here, but it seems like if folks want to add extra ci setup packages, then we should have added a new optional originally called "extra_ci_setup" or similar.
In any case, most things are half-broken most of the time. I'll defer to the rest of core here.
cc @conda-forge/core
There was a problem hiding this comment.
I had originally proposed something like extra, it was rejected. I think we hadn't considered the bootstrap procedure. Selfishly speaking, i don't have many reasons to push this PR forward
There was a problem hiding this comment.
That is totally fine. Let's close this one and leave things as they are. We can go back and fix later by making the conda-forge specific stuff a separate option since it is special anyways. Thank you for all of the hard work here!
|
closing as stated above! |
This attempts to help the bootstrap process uninstall any pre-installed version of
conda-forge-ci-setup.I've added comments to the effect where I knew how to do it in the relevant syntax.
The purpose of specifying extra packages was specifically designed in to avoid needless churn with the
tensorflowpackage which depends onlief_devwhich has not had a new release in about 8 months.I'm really trying to contain scope creep here and not balloon the options provided in
conda-forge.ymlReferences:
Lief releases: https://github.com/lief-project/LIEF/releases
Request to use lief dev: conda-forge/tensorflow-feedstock#189 (comment)
Interested parties: @beckermr @isuruf @xhochy
Checklist
newsentry