-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status page: do not error if migration details can't be fetched; show zeros instead #2390
Status page: do not error if migration details can't be fetched; show zeros instead #2390
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This fixes it, but if you click on the errored migration, it confusingly takes you back to the status page. Is that too bad? We can throw a 404-like error, but not sure if that's useful. Maybe I'll try to remove the link if no details were fetched... |
Maybe we can mark the row with |
Check last commit, we had the same thought :) |
Co-authored-by: Matthew R. Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you!
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
fileCloses #2389. If the URLs are missing, all migrations will have progress 0. See screenshot for simulated failure mode (I changed the URLs in
constants.js
locally for this):