Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status page: do not error if migration details can't be fetched; show zeros instead #2390

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

jaimergp
Copy link
Member

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

Closes #2389. If the URLs are missing, all migrations will have progress 0. See screenshot for simulated failure mode (I changed the URLs in constants.js locally for this):

image

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit daf5366
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/67485fc0d5ce430008f49484
😎 Deploy Preview https://deploy-preview-2390--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaimergp
Copy link
Member Author

This fixes it, but if you click on the errored migration, it confusingly takes you back to the status page. Is that too bad? We can throw a 404-like error, but not sure if that's useful. Maybe I'll try to remove the link if no details were fetched...

@beckermr
Copy link
Member

Maybe we can mark the row with (failed to load) after the migration name and not make the title a link at all?

@jaimergp
Copy link
Member Author

Check last commit, we had the same thought :)

@jaimergp jaimergp marked this pull request as ready for review November 28, 2024 12:19
@jaimergp jaimergp requested a review from a team as a code owner November 28, 2024 12:19
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@beckermr beckermr merged commit f0079d7 into conda-forge:main Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

status page fails if json cannot be loaded
2 participants