Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meeting notes 2024-11-27 #2388
Add meeting notes 2024-11-27 #2388
Changes from 2 commits
3f69899
17afd3f
fe25196
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the outcome of this discussion? I remember that @jjerphan and colleagues were interested in this. AFAIU it's an ABI break though, so we'd probably have to queue that up for whenever we rebuild the world?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For such a change, I would be more than prudent and assume that ABI-compatibility depends on platforms.
If they were to be activated again, I guess the best would be to have a conda-forge reboot or at least a batch rebuild for an entire set of packages.
See this part of Fedora Project Wiki for more information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actually an ABI break to activate frame pointers? That sounds unexpected to me: you can compile any code with or without frame pointers, and still link to the same existing third-party or system libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhochy was going to make a PR and see what people said
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but could it in practice alter some calling conventions?
I am not knowledgeable or experienced enough to be able to tell; I think it might be worth contacting people who re-activated them on RPM-based or DEB-based distributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm confused about whether this would change the ABI. My understanding is that a specific register is always filled, independent of whether the function uses it or not. I don't think this should be a world-rebuilt.
Let's move this discussion to the PR over here: conda-forge/clang-compiler-activation-feedstock#151