Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin zarr<3 in ome-zarr #940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pin zarr<3 in ome-zarr #940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions recipe/patch_yaml/ome-zarr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# yaml-language-server: $schema=../patch_yaml_model.json
# from this bit of code

# zarr 2.18.x dropped support for Python 3.10 in a patch release with
# https://github.com/zarr-developers/zarr-python/pull/2344 following
# https://scientific-python.org/specs/spec-0000/

# PRs https://github.com/conda-forge/ome-zarr-feedstock/pull/22
# and https://github.com/conda-forge/ome-zarr-feedstock/pull/23
# dealt with the immediate build issues.
if:
name: ome-zarr
version_lt: "0.10.3"
timestamp_lt: 1736594995
# Saturday, January 11, 2025 12:29:55 PM GMT+01:00
then:
- tighten_depends:
name: zarr
upper_bound: 3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have the intended effect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running:

python show_diff.py --subdirs noarch

locally

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking like even less ...

(conda-patches) /opt/conda-forge-repodata-patches-feedstock/recipe $python show_diff.py --subdirs noarch
================================================================================
================================================================================
noarch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, so now you can debug why your patch isn't working.

Loading