Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new abseil/grpc/protobuf migration #6452

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

h-vetinari
Copy link
Member

This has been a long time coming, but we managed to unblock the protobuf situation now after upstream forced a build backend change to bazel (which itself depends on protobuf in our builds).

I'm adding the migration as paused for now to build out the baseline packages.

See also #4075, and the sketched plan. There's already grpc 1.66 & libprotobuf 5.28.2, but given that this is all very fresh, I'd prefer to do smaller version jumps, and fix things as we go. Once we've got this migration out of the way, we can jump to the newest builds.

CC @conda-forge/abseil-cpp @conda-forge/grpc-cpp @conda-forge/libprotobuf @conda-forge/protobuf

@h-vetinari h-vetinari requested a review from a team as a code owner September 22, 2024 21:31
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

I'm a little concerned that I just just merged the mkl=2024 migration which may have alot of overlap with packages that use protobuf.

I am also selfishly concerned with the fact that I've been stuck on pytorch's aarch build conda-forge/pytorch-cpu-feedstock#256 for the last 3 weeks (yes many are helping, but we are still working through things).

@h-vetinari
Copy link
Member Author

We're not ready to start migrating (hence also why this migration is still paused in this PR). We need at least conda-forge/grpc-cpp-feedstock#370 for example.

Happy to wait for MKL to advance a bit, a few days more or less will not change things after months of waiting. However, I don't want to wait for the likes of pytorch/tensorflow - those move at a slower speed than the rest of conda-forge, so it'd be completely fine IMO to finish your PR there as-is in however long that takes, and we worry about the migration for pytorch afterwards.

@h-vetinari h-vetinari merged commit 8f554c2 into conda-forge:main Sep 23, 2024
3 checks passed
@h-vetinari h-vetinari deleted the agp branch September 23, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants