-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close out protobuf 4.23.3 migration; drop protobuf 3.21 #4768
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I just noticed that closing this migration effectively means requiring MacOS >=10.13, because a protobuf 4.x-compatible grpc requires C11's Just collecting dependencies of
This results in ~280 affected packages, and that's not even counting transitive dependencies (much less the fact that pandas is planning to depend on pyarrow). So I'm afraid this is now coupled with the MacOS discussion. 😑 List of affected packages (first-order dependent on grpc/arrow)
|
not sure if i want to fully close out the migrations if pytorch/tensorflow are still running. can we soft-close instead? i.e. bump the global pins but leave the migrator running. |
@hmaarrfk, I tried to do that now - could you PTAL? I left the zip in because we still need it for the old migrator, and we'll need it as well for the introduction of 4.24.x. |
thanks. |
TBH, I didn't expect we'd merge yet given
But at least it seems everyone's on board and we'll be able to go ahead with the announcement after the core call. 🤞 |
I thought everybody was on the same page to move forward with it (albeit with some announcements) |
I guess we might as well close things off. I'm not too interested in building both protobufs for pytorch and tensorflow, they are pretty difficult as is. |
This has been going on for a while now, it's almost 3 months since #4482.
The remaining feedstocks are
Given that we have protobuf 4.23.4 and 4.24.0 ready to migrate (plan), I think we should move on and drop 3.x.
CC @conda-forge/core
Footnotes
I'm working on some ABI issues but solvable ↩