WIP: Feature/login history #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: chore: bump root package version v6.0.0-alpha.1 fix: crud builder swagger decorator improvements Conflicts: packages/nestjs-auth-apple/package.json packages/nestjs-auth-github/package.json packages/nestjs-auth-google/package.json packages/nestjs-auth-local/package.json yarn.lock
* main: fix: revert deleted code comment about security chore: update default logo path chore: linting chore: add active for missing classes chore: linting chore: add logo to all email itemplates chore: add logo to templates chore: add option to overwrite rate limit for invitation and recovery chore: add otp status and limit validation chore: new package proposal chore: template for feature requests
* main: feat: move event manager options to contructor feat: fix tsdoc type feat: implement event manager on dependent modules feat: add event manager
|
I feel like we should be doing the logging in the strategy instead of the controller. Just in general I want to avoid doing logic in the controller whenever possible. You can get the req in the strategy callback with the |
|
What if we get an error after the strategy? at the time to generate the payload with access token? |
I think this is two different things.
We have an outstanding TODO item related to emitting an event when the token is issued. |
|
in that case i believe it make sense to do on strategy, i will make the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.