Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modernize MediaQuery usage #520

Merged
merged 3 commits into from
Nov 15, 2024
Merged

refactor: Modernize MediaQuery usage #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47f5905
Modernize MediaQuery usage
cabaucom376 Nov 14, 2024
90f6cfe
Merge branch 'main' into refactor/mediaquery-optimizations
leoafarias Nov 15, 2024
0946a5e
Merge branch 'main' into refactor/mediaquery-optimizations
leoafarias Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mix/lib/src/variants/context_variant_util/on_brightness_util.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class OnBrightnessVariant extends MediaQueryContextVariant {
/// [brightness] associated with this variant, and `false` otherwise.
@override
bool when(BuildContext context) {
final mediaBrightness = MediaQuery.of(context).platformBrightness;
final mediaBrightness = MediaQuery.platformBrightnessOf(context);

return mediaBrightness == brightness;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/mix/lib/src/variants/context_variant_util/on_orientation_util.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class OnOrientationVariant extends MediaQueryContextVariant {
/// [orientation] associated with this variant, and `false` otherwise.
@override
bool when(BuildContext context) {
return MediaQuery.of(context).orientation == orientation;
return MediaQuery.orientationOf(context) == orientation;
}

/// The properties used for equality comparison.
Expand Down
Loading