Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rewrite FlexBox as a Mix's primitive component #517

Merged
merged 11 commits into from
Nov 15, 2024
Merged

feat: Rewrite FlexBox as a Mix's primitive component #517

merged 11 commits into from
Nov 15, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Nov 12, 2024 •
edited
Loading

Description

Rewrite FlexBox as a primitive widget. Now it has its own Spec called FlexBoxSpec and can be stylized using $flexbox

Changes

  • Rewrite FlexBox.
  • Create FlexBoxSpec, FlexBoxSpecAttribute and FlexBoxUtility
  • Implement some tests
  • Fix a bug to set textBaseline, textDirection and clipBehavior on StyledFlex.

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Additional Information (optional)

Is there any additional context or documentation that might be helpful for reviewers?

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 5:05pm

@github-actions github-actions bot added the mix label Nov 12, 2024
leoafarias
leoafarias approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 4ea6efe into main Nov 15, 2024
4 of 6 checks passed
@leoafarias leoafarias deleted the feat/flexbox branch November 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
mix_generator mix_lint mix remix repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias