Skip to content

Commit

Permalink
remove orderOfModifiers
Browse files Browse the repository at this point in the history
  • Loading branch information
tilucasoli committed Nov 14, 2024
1 parent 2de2a79 commit b87ab90
Showing 1 changed file with 8 additions and 18 deletions.
26 changes: 8 additions & 18 deletions packages/mix/lib/src/specs/icon/icon_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@ class StyledIcon extends StyledWidget {
this.textDirection,
@Deprecated('Use orderOfModifiers parameter instead')
List<Type> modifierOrder = const <Type>[],
List<Type> orderOfModifiers = const <Type>[],
}) : assert(modifierOrder.length == 0 || orderOfModifiers.length == 0),
super(
orderOfModifiers:
orderOfModifiers == const [] ? modifierOrder : orderOfModifiers,
);
super.orderOfModifiers = const <Type>[],
});

final IconData? icon;
final String? semanticLabel;
Expand Down Expand Up @@ -59,10 +55,8 @@ class IconSpecWidget extends StatelessWidget {
this.textDirection,
@Deprecated('Use orderOfModifiers parameter instead')
List<Type> modifierOrder = const <Type>[],
List<Type> orderOfModifiers = const <Type>[],
}) : assert(modifierOrder.length == 0 || orderOfModifiers.length == 0),
orderOfModifiers =
orderOfModifiers.length == 0 ? modifierOrder : orderOfModifiers;
this.orderOfModifiers = const <Type>[],
});

final IconData? icon;
final IconSpec? spec;
Expand Down Expand Up @@ -103,10 +97,8 @@ class AnimatedStyledIcon extends StyledWidget {
@Deprecated('Use orderOfModifiers parameter instead')
List<Type> modifierOrder = const <Type>[],
List<Type> orderOfModifiers = const <Type>[],
}) : assert(modifierOrder.length == 0 || orderOfModifiers.length == 0),
super(
orderOfModifiers:
orderOfModifiers.length == 0 ? modifierOrder : orderOfModifiers,
}) : super(
orderOfModifiers: false ? modifierOrder : orderOfModifiers,

Check warning on line 101 in packages/mix/lib/src/specs/icon/icon_widget.dart

View workflow job for this annotation

GitHub Actions / Test

Dead code.

Try removing the code, or fixing the code before it so that it can be reached. See https://dart.dev/diagnostics/dead_code to learn more about this problem.

Check warning on line 101 in packages/mix/lib/src/specs/icon/icon_widget.dart

View workflow job for this annotation

GitHub Actions / Test Min SDK

Dead code.

Try removing the code, or fixing the code before it so that it can be reached. See https://dart.dev/diagnostics/dead_code to learn more about this problem.
);

final AnimatedIconData icon;
Expand Down Expand Up @@ -143,10 +135,8 @@ class AnimatedIconSpecWidget extends ImplicitlyAnimatedWidget {
super.onEnd,
@Deprecated('Use orderOfModifiers parameter instead')
List<Type> modifierOrder = const <Type>[],
List<Type> orderOfModifiers = const <Type>[],
}) : assert(modifierOrder.length == 0 || orderOfModifiers.length == 0),
orderOfModifiers =
orderOfModifiers.length == 0 ? modifierOrder : orderOfModifiers;
this.orderOfModifiers = const <Type>[],
});

final IconData? icon;
final IconSpec spec;
Expand Down

0 comments on commit b87ab90

Please sign in to comment.