fix: footer links and menu overlay are displayed better on mobile #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayokamoto
temporarily deployed
to
Development
GitHub Actions
Inactive
jsun969
approved these changes
Feb 25, 2025
rayokamoto
force-pushed
the
fix/mobile-view
branch
from
7e31f38 to
715bc12
Compare
rayokamoto
temporarily deployed
to
Development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the footer icons would overflow the margins on mobile since there were so many of them and thee was no wrapping logic. This has been fixed.
The mobile menu overlay resulted in the background being scrollable, while the overlay itself wasn't which is annoying when some links are cropped out. The fix for this was disabling overflow-y for the main page when the menu was open while enabling overflow-y for the menu only. The height of the menu has also been changed from 100% to 100dvh which should make the experience nicer on mobile.