Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip the argument order of Replace in window folds #2901

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Flip the argument order of Replace in window folds #2901

merged 1 commit into from
Dec 16, 2024

Conversation

adithyaov
Copy link
Member

@adithyaov adithyaov commented Dec 15, 2024 •
edited
Loading

  • Change Repalce1 back to Replace

Used Replace1 to ensure all the followup changes.

@adithyaov adithyaov linked an issue Dec 15, 2024 that may be closed by this pull request
Change the Replace constructor argument order #2883
Closed
harendra-kumar
harendra-kumar approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the todo comment:
-- XXX Use "Replace old new" instead.

Change this doc:

  1. An input of type @(Replace a a)@ indicates that the first argument of
    -- Replace is being inserted in the window and the second argument is being
    -- removed from the window

@adithyaov adithyaov merged commit 4e7b848 into master Dec 16, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harendra-kumar harendra-kumar harendra-kumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the Replace constructor argument order
2 participants
@adithyaov @harendra-kumar