allow additional_context to target another service #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @crazy-max |
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
additional_context_service
branch
from
25e1083 to
f42e1a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for
service:xxsyntax defining an additional context.this will be used to explicitly request another service image being used as source for another service. This is a long term issue inherited from compose v1 sequential build logic: some users declare image built by another service as
FROMinstruction in another service's Dockerfile. They will be able to keep this working by adding an explicit additional_context asservice: baseappand let buildkit manage best possible execution of the build.see https://github.com/docker/buildx/blob/v0.8.0-rc1/docs/reference/buildx_bake.md#using-a-result-of-one-target-as-a-base-image-in-another-target
illustration with docker/compose : docker/compose#12485