fix: logo getting cropped in landscape mode of login page #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for noticing. it has been fixed! |
Sujal-Gupta-SG
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Review by GSoC applicant
I don't think this is needed , i've run both without change and after change both are correct may be in some device there can be issue But i think this change is Better
The login card is in center which looks Good and better than before
**Tests performed **
Tested on:
- Build variant: ProdDebug
- Device: Realme Narzo 20
- API Level: 30-ext15
|
Thanks for the review! 😊 |
misaochan
requested changes
Jan 6, 2025
misaochan
approved these changes
Jan 7, 2025
|
Thanks @QuantumPineapple68 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change: Bug fix (non-breaking change which fixes an issue)
Fixed logo getting cropped when the device is in landscape mode.
The login frame is moved to the center for better visuals in vertical mode.
What changes did I made and why?
android:layout_gravity="center_vertical"toScrollViewandLinearLayoutFrameLayoutwill always appear at the centre of the screen for better visuals irrespective of screen size.Tests performed (required)
Screenshots (for UI changes only)
BEFORE:
AFTER:
