Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev reenable packages #7338

Closed
wants to merge 2 commits into from

Conversation

turion
Copy link
Contributor

@turion turion commented Mar 6, 2024

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)
  • (optional) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@turion
Copy link
Contributor Author

turion commented Mar 6, 2024

@turion
Copy link
Contributor Author

turion commented Mar 6, 2024

There are several transitive dependencies of finite-typelits that are currently excluded. Should I aim at testing them & bringing them back as well?

@DanBurton
Copy link
Contributor

@turion yes. Or you can just urge their maintainers to do so.

@juhp
Copy link
Contributor

juhp commented May 10, 2024

Perhaps we can close for now and you can (re)open when ready, thank you! :)

@juhp juhp closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants