PR: Prepare Project for First Release Part II #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se `element_as_text` which internally creates the string representation.
MichaelMauderer
force-pushed
the
feature/pr_feedback
branch
from
59cbcca to
1309ac3
Compare
KelSolaar
requested changes
Feb 1, 2025
| """ | ||
| Return the default SOPNode instance. Contains the default values that | ||
| should be used per specification in case the actual value is not provided. | ||
| """ |
There was a problem hiding this comment.
Would it be please possible to add the Returns docstring section?
Returns
--------
...
Same for the others, after this we are gold! Cheers.
KelSolaar
approved these changes
Feb 3, 2025
|
Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement further feedback from #2
Preflight
Code Style and Quality
Documentation