Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checkbox column #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix checkbox column #4

wants to merge 4 commits into from

Conversation

petschki
Copy link
Member

do not loose information on checkboxes when validating a form

@petschki
Copy link
Member Author

Somebody willing to review this?

@mauritsvanrees
Copy link
Member

Hi, sorry to keep you waiting so long.

It works as advertised with your changes, but there is a side effect, maybe mostly because of f16e19d. The datagrid demo type 2, available if you apply the example types via portal_setup, has a DemoField3: a grid with a radio column and a checkbox column. Add three rows:

radio   checkbox
1         True
2         False
1         True

Now save it. The result is that the radio values are fine, but all True checkbox values have moved to the top:

radio   checkbox
1         True
2         True
1         False

If you are still interested, can you have a look at that?

Looks like the same would be needed for radio columns, but that can be done another time.

While trying to merge locally with master, the javascript changes were hard to merge because that file has changed meanwhile and it looks like you are combining some whitespace cleanup and an actual change and I don't quite see what that actual change is. :-) I have pushed the merged branch to petschki-checkbox. Feel free to continue on that branch or ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants