Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass params from wire function to TestComponentSpec. #134

Merged

Conversation

davidsf
Copy link

@davidsf davidsf commented Dec 13, 2023

This PR fix two issues with tests:

  • In tests if you pass arguments to the wire function, there are not passed to the test component.

  • The test component uses mount and throws a MissingMethod exception. Also, it links with .renderIt() but onMount doesn't return the object, so I put in two sentences.

Copy link
Collaborator

@grantcopley grantcopley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidsf Thank you for the improvement! Merging.

@grantcopley grantcopley merged commit 3b1b0e2 into coldbox-modules:development Dec 13, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants