Skip to content

Commit

Permalink
Update some comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
broneill committed Feb 6, 2025
1 parent 837644b commit 8165cab
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 14 deletions.
5 changes: 3 additions & 2 deletions src/main/java/org/cojen/dirmi/core/Stub.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
import org.cojen.dirmi.Remote;

/**
* Base class for remote stubs. It must not declare any new public instance methods because
* they can conflict with user-specified remote methods which have the same signature.
* Base class for remote stubs. It must not declare any new public or protected instance
* methods because they can conflict with user-specified remote methods which have the same
* signature.
*
* @author Brian S O'Neill
*/
Expand Down
20 changes: 10 additions & 10 deletions src/main/java/org/cojen/dirmi/core/StubInvoker.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

/**
* Base class for remote stubs which actually invoke the remote methods over the pipe. This
* class must not declare any new public instance methods because they can conflict with
* user-specified remote methods which have the same signature.
* class must not declare any new public or protected instance methods because they can
* conflict with user-specified remote methods which have the same signature.
*
* @author Brian S. O'Neill
*/
Expand Down Expand Up @@ -142,8 +142,8 @@ long resetTransportCount() {

/**
* Base class for invokers which support automatic disposal. This class must not declare
* any new public instance methods because they can conflict with user-specified remote
* methods which have the same signature.
* any new public or protected instance methods because they can conflict with
* user-specified remote methods which have the same signature.
*/
private static abstract class WithRef extends StubInvoker {
private StubWrapper.Factory wrapperFactory;
Expand Down Expand Up @@ -188,9 +188,9 @@ long resetTransportCount() {

/**
* Base class for invokers which support automatic disposal and don't have any methods for
* which "isUnacknowledged" is true. This class must not declare any new public instance
* methods because they can conflict with user-specified remote methods which have the same
* signature.
* which "isUnacknowledged" is true. This class must not declare any new public or
* protected instance methods because they can conflict with user-specified remote methods
* which have the same signature.
*/
public static abstract class WithBasicRef extends WithRef {
private AutoDisposer.BasicRef ref;
Expand Down Expand Up @@ -218,9 +218,9 @@ final Stub select() {

/**
* Base class for invokers which support automatic disposal and have at least one method
* for which "isUnacknowledged" is true. This class must not declare any new public
* instance methods because they can conflict with user-specified remote methods which have
* the same signature.
* for which "isUnacknowledged" is true. This class must not declare any new public or
* protected instance methods because they can conflict with user-specified remote methods
* which have the same signature.
*/
public static abstract class WithCountedRef extends WithRef {
protected AutoDisposer.CountedRef ref;
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/cojen/dirmi/core/StubWrapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

/**
* Base class for remote stubs which delegate to an invoker for supporting AutoDispose. This
* class must not declare any new public instance methods because they can conflict with
* user-specified remote methods which have the same signature.
* class must not declare any new public or protected instance methods because they can
* conflict with user-specified remote methods which have the same signature.
*
* @author Brian S. O'Neill
*/
Expand Down

0 comments on commit 8165cab

Please sign in to comment.