Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] bootstrap balances should be done only for genesis block testing #375

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

shrimalmadhur
Copy link
Contributor

Fixes # .

Motivation

When we run parallel validation from any block other then genesis, we are using bootstrap_balances.json to initialize balances which results into balance mismatch because actual balances in n-1 block might have been updated and we need to use that.

Solution

Add a condition to validation that, bootstrap balances only if startIndex is empty or is genesis block.

Open questions

@shrimalmadhur shrimalmadhur merged commit 11cc4ab into master Dec 8, 2022
@shrimalmadhur shrimalmadhur deleted the madhur/fix-bootstrap-behavior branch December 8, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants